X Tutup
The Wayback Machine - https://web.archive.org/web/20230329061838/https://github.com/PowerShell/PowerShell/issues/13178
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows Event-ID 53504 PowerShellCore text description. #13178

Closed
MaximoTrinidad opened this issue Jul 15, 2020 · 4 comments
Closed

Fix Windows Event-ID 53504 PowerShellCore text description. #13178

MaximoTrinidad opened this issue Jul 15, 2020 · 4 comments
Labels
Issue-Enhancement the issue is more of a feature request than a bug Resolution-External The issue is caused by external component(s). WG-Engine core PowerShell engine, interpreter, and runtime

Comments

@MaximoTrinidad
Copy link

Summary of the new feature/enhancement

Currently, in the PowerShellCore, for the event-id 53504, is displaying the following message:
"Windows PowerShell has started an IPC listening thread on process: 10108 in AppDomain: DefaultAppDomain."

Notice that in the event text is displaying "Windows PowerShell" when it should display "PowerShell".

At the same time, I think it's time to get rid of "PowerShellCore" and simply use "PowerShell".

PSEvent_01_2020-07-15_9-09-51

Proposed technical implementation details (optional)
@MaximoTrinidad MaximoTrinidad added the Issue-Enhancement the issue is more of a feature request than a bug label Jul 15, 2020
@MaximoTrinidad MaximoTrinidad mentioned this issue Jul 16, 2020
Closed
@adityapatwardhan
Copy link
Member

adityapatwardhan commented Jul 16, 2020 •
edited by unfurl-links bot

@SteveL-MSFT - I believe the manifest for the win events come from here: https://github.com/PowerShell/PowerShell-Native/blob/master/src/PowerShell.Core.Instrumentation/PowerShell.Core.Instrumentation.man

Once I get an ack, I will transfer the issue to https://github.com/PowerShell/PowerShell-Native

GitHub
Contribute to PowerShell/PowerShell-Native development by creating an account on GitHub.
GitHub
Contribute to PowerShell/PowerShell-Native development by creating an account on GitHub.

@MaximoTrinidad
Copy link
Author

@adityapatwardhan

In today's PowerShell Community Call, @SteveL-MSFT asked me to create a PR for this one.
Let me know what you think.

:)

@MaximoTrinidad
Copy link
Author

MaximoTrinidad commented Jul 16, 2020 •
edited

@adityapatwardhan / @SteveL-MSFT

Hum! Looking at the code in PowerShell.Core.Instrumentation.man...

What do you guys want to do with the "ISE" portion of it? Knowing that there's no ISE for PowerShellCore.
Can it be removed?

:)

@iSazonov iSazonov added WG-Engine core PowerShell engine, interpreter, and runtime Resolution-External The issue is caused by external component(s). labels Jul 20, 2020
@msftbot
Copy link

msftbot bot commented Jul 21, 2020

This issue has been marked as external and has not had any activity for 1 day. It has been be closed for housekeeping purposes.

@msftbot msftbot bot closed this as completed Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Enhancement the issue is more of a feature request than a bug Resolution-External The issue is caused by external component(s). WG-Engine core PowerShell engine, interpreter, and runtime
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adityapatwardhan @MaximoTrinidad @iSazonov
X Tutup