Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert "Add many more global analyses. (#47875)" #48080
Merged
Conversation
franciscojma86
merged commit 04ea318
into
flutter:master
3 of 53 checks passed
3 of 53 checks passed
flutter-build
Flutter build is currently broken. Please do not merge this PR unless it contains a fix to the broken build.
Details
cla/google
All necessary CLAs are signed
|
LGTM |
|
Actually maybe not. Can you link to the job that it broke? The only red I see on this commit is from an unrelated flake (#43763). I think we should reland this. And in the future, can you include a link to the breakage in the message? |
dnfield
added a commit
that referenced
this pull request
Jan 2, 2020
|
Yeah that was the broken job.
Will do! |
franciscojma86
added a commit
that referenced
this pull request
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
franciscojma86 commentedJan 2, 2020
•
edited
This reverts commit e768c92.
This is breaking the build. TBR @Hixie