Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow "getting" and setting case_sensitive_like pragma #1494
Conversation
This comment has been minimized.
This comment has been minimized.
|
Haha, that's pretty clever |
This comment has been minimized.
This comment has been minimized.
|
Hmmm, let's merge it and see how it goes in actual use? |
This comment has been minimized.
This comment has been minimized.
|
@MKleusberg You're probably right about why this pragma is write-only. Though it would make sense to implement a read interface returning ON, OFF, OTHER. The OTHER value would not be accepted in the write. But anyway, the pragma seems useful and I think we could add an information tooltip over the value: Warning: this pragma is not readable and this value has been inferred. Writing the pragma might overwrite a redefined LIKE provided by an SQLite extension. The only way to have a redefined LIKE is by the user having loaded an extension through DB4S, isn't? In that case it would be possible to know in most cases whether that is a problem at all. |
This comment has been minimized.
This comment has been minimized.
|
Yep, that warning sounds right. Want to add it and then merge this? |
This comment has been minimized.
This comment has been minimized.
Of course. |
This comment has been minimized.
This comment has been minimized.
|
Awesome, I'll merge this then |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

mgrojo commentedAug 5, 2018
In order to allow case insensitive filtering, the pragma
case_sensitive_like is added to the GUI. Given that this pragma cannot be
read, a special SELECT request is made in DBBrowserDB::getPragma for
inferring its value.
See issue #1489.
I think this cannot give any problem, but just in case, I open this pull request with the implementation.