Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove 4k/5k resolution rendering speed on macOS/OSX #1233
Conversation
SourceTrigger
added some commits
Nov 20, 2017
SourceTrigger
referenced this pull request
Nov 20, 2017
Closed
You need a trick for macOS on 4k/5k #1232
This comment has been minimized.
This comment has been minimized.
|
Thanks @SourceTrigger. I'll try building this and running it on OSX, Windows, and Linux some time today, just to make sure no unexpected weirdness shows up. If all goes well, this'll be merged after that. |
justinclift
added
the
osx
label
Nov 20, 2017
justinclift
self-assigned this
Nov 20, 2017
justinclift
changed the title
Source trigger patch mac os
Improve 4k/5k resolution rendering speed on macOS/OSX
Nov 20, 2017
This comment has been minimized.
This comment has been minimized.
|
Excellent. Builds and works ok here on Win 7, Linux (Fedora 25 x64), and OSX 10.11.6 (non 4k/5k resolution though). Thanks for reporting this and getting it fixed. We wouldn't have even known about it otherwise. |
justinclift
merged commit de2131d
into
sqlitebrowser:master
Nov 20, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
SourceTrigger
deleted the
SourceTrigger:SourceTrigger-patch-macOS
branch
Nov 20, 2017
justinclift
added this to the 3.11.0 - Where we take over the world! :D milestone
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
SourceTrigger commentedNov 20, 2017
On macOS in 4k and 5k resolutions the program runs very slowly. For Qt to render via OpenGL, a QOpenGLWidget must be added.