Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded hide selected columns and show all columns to tableview context… #1135
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks @peteristhegreat, that's excellent. @MKleusberg will probably review this tomorrow, and if it's in good shape (which it seems like from eyeballing it just now), then merge it in. |
justinclift
added
the
enhancement
label
Sep 12, 2017
MKleusberg
requested changes
Sep 13, 2017
|
Thank you very much, @peteristhegreat |
| @@ -9,6 +9,9 @@ | |||
| */ | |||
|
|
|||
| #include <antlr/config.hpp> | |||
| #ifdef __MINGW32__ | |||
| #include <cstring> | |||
| #endif | |||
This comment has been minimized.
This comment has been minimized.
MKleusberg
Sep 13, 2017
Member
Can you move this into a separate commit because it isn't directly linked to the hide column feature?
This comment has been minimized.
This comment has been minimized.
peteristhegreat
Sep 13, 2017
Author
Contributor
When I pulled the project on Windows 10 to build it, I had issues with strcpy, and in the build order, this was the first header that complained about strcpy_s issues. I agree that it could be put in as a separate issue or commit. The commit string does mention it, on the second line.
| { | ||
| ui->dataTable->showColumn(1); | ||
| ui->dataTable->resizeColumnToContents(1); | ||
| } |
This comment has been minimized.
This comment has been minimized.
MKleusberg
Sep 13, 2017
Member
Can you add an entry to struct BrowseDataTableSettings in MainWindow.h for saving the hidden flag of each column? It would more or less need to be implemented and used like the columnWidths member.
This would make the hidden columns stay hidden when changing to another table and coming back to the original table later. It would also save the hidden columns in the project files.
If you're unsure about this, that's no problem either. We can just merge the commit then and I'll add this later
This comment has been minimized.
This comment has been minimized.
peteristhegreat
Sep 13, 2017
Author
Contributor
If you could add it in later, that would be great!
I don't think I can really dig into the full column-width persistence in the near future.
Just FYI about that usage... I know that when you say showColumn() in Qt 4, QTableView doesn't respect previous column sizes for all but the most recently hidden column. Any after the first column that have been hidden, get a width of zero. It took me a while to figure that one out... this post on stackoverflow that helped point out the issue for me. https://stackoverflow.com/a/7595202/999943
This comment has been minimized.
This comment has been minimized.
MKleusberg
Sep 18, 2017
Member
Cool, thanks for the information
MKleusberg
approved these changes
Sep 18, 2017
This comment has been minimized.
This comment has been minimized.
|
No problem |
peteristhegreat commentedSep 12, 2017
… menu.
Added a fix for building with MingW on Windows.