X Tutup
The Wayback Machine - https://web.archive.org/web/20200707225350/https://github.com/github/explore/issues/1473
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ownership Request: Explore Team #1473

Open
mms710 opened this issue May 10, 2020 · 9 comments
Open

Ownership Request: Explore Team #1473

mms710 opened this issue May 10, 2020 · 9 comments

Comments

@mms710
Copy link

@mms710 mms710 commented May 10, 2020

We're doing the first round of follow-ups based on research that a group of senior and staff engineers did on ownership for items in the service catalog. We want to suggest/ask if your team is willing to own the following items and has the staffing to do so. It's possible that this question might arise just due to out of date documentation and you already do own these items, but we want to make sure to check in and get your team's explicit approval or disapproval because we want to make sure there's no surprises as part of this process. If you do agree to own these items, we would ask that your team updates the ownership.yaml file referenced in the service catalog to show your ownership. As a note, this is just the first round of research on the items the team felt were most critical, and we expect to do one more round once we've done a more thorough review of the remaining items.

Requests:

  • Review the list of below services and either accept or reject ownership for them. If you don't think you are the right owner for something, please let us know if you have any ideas of who might be the correct team.
  • For any services you accept, please link issues or PRs to this issue to update the service catalog for these items so we can have up to date records as we continue on our ownership research

Due Dates:
We would ideally like to have an answer on this and a PR to fix the underlying documentation by May 15th. However, this is a short timeline so please feel free to push back if that won't work for the team.

List of Services:

(cc @derekprior )

@derekprior
Copy link

@derekprior derekprior commented May 11, 2020

@kenyonj I feel like you and I had talked about explore-feed in the past and you mentioned that it was unused? Should I retire it from the service catalog?

I don't know what Marketing Crons is, but the name strikes me as being more closely related to @github/site-engineering cc @talsafran for thoughts?

@kenyonj
Copy link
Collaborator

@kenyonj kenyonj commented May 11, 2020

@kenyonj I feel like you and I had talked about explore-feed in the past and you mentioned that it was unused? Should I retire it from the service catalog?

That’s correct @derekprior. explore-feed is not used anywhere and was just an experiment.

@talsafran
Copy link
Member

@talsafran talsafran commented May 11, 2020

👋 I think marketing-crons can be retired too... happy to take over ownership and retire it.

@mms710
Copy link
Author

@mms710 mms710 commented May 12, 2020

@talsafran would you be willing to open a PR and link it to this issue for your team to take on ownership of marketing-crons and retire it?

@derekprior would it make sense for your team to take on explore-feed and retire it, or should that also live with site-engineering?

@talsafran
Copy link
Member

@talsafran talsafran commented May 13, 2020

@mms710 can happily do that.

So, I probably should've asked this yesterday 😊:

  • To update ownership, do you mean just update repo's ownership.yaml file? Or is there another source of truth?

  • What's involved in retiring a service exactly? Is there a playbook? I couldn't find any documentation, would love a nudge in the right direction 🙃

@derekprior
Copy link

@derekprior derekprior commented May 13, 2020

It makes sense for us to take explore-feed. @kenyonj - are you able to grant me access to the github/explore-feed repo?

@derekprior
Copy link

@derekprior derekprior commented May 13, 2020

What's involved in retiring a service exactly? Is there a playbook? I couldn't find any documentation, would love a nudge in the right direction 🙃

I'm trying to figure this out too! In the case of explore-feed, it seems like the moda app is alredy deprovisioned, so I think I just need to remove the ownership information from the repo?

@kenyonj
Copy link
Collaborator

@kenyonj kenyonj commented May 13, 2020

It makes sense for us to take explore-feed. @kenyonj - are you able to grant me access to the github/explore-feed repo?

Just added @github/explore as admins on the github/explore-feed repo

@mms710
Copy link
Author

@mms710 mms710 commented May 14, 2020

@talsafran Thanks for asking! You are absolutely correct that the next step to officially "claim" the service is to update the ownership.yaml file for the service.

@derekprior is absolutely right that we don't have a playbook for how to sunset a service (yet!). I'd recommend working with your product counterparts first to determine if any customer communications are needed before you sunset the service, then tackling the engineering portion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.
X Tutup