X Tutup
The Wayback Machine - https://web.archive.org/web/20200914053603/https://github.com/github/octodns/pull/53
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major reworking of root NS handling, create & update, no delete #53

Open
wants to merge 6 commits into
base: master
from

Conversation

@ross
Copy link
Contributor

ross commented Jun 4, 2017

  • Cloudflare, Dyn & DnsimpleProvider don't support editing root NS records, Dyn may be
    able to sort of, but you can't remove their own...
  • Improve DnsimpleClient's info on http errors
  • Remove special root NS handling code from PowerDnsProvider, in this the
    case it used to support things should now be managed in the zone. Dynamic
    support still exists in PowerDnsBaseProvider to enable "other" use cases
  • _is_eligible removed from zone, all records are eligible as far as it's
    concerned now.
  • Bunch of tweaks to tests to handle the fact that root NS stuff are now
    included in changes.

Closes #38

- Can't get in to test Cloudflare so mark it as unknown state
- Dyn & DnsimpleProvider don't support editing root NS records, Dyn may be
  able to sort of, but you can't remove their own...
- Improve DnsimpleClient's info on http errors
- Remove special root NS handling code from PowerDnsProvider, in this the
  case it used to support things should now be managed in the zone. Dynamic
  support still exists in PowerDnsBaseProvider to enable "other" use cases
- _is_eligible removed from zone, all records are eligible as far as it's
  concerned now.
- Bunch of tweaks to tests to handle the fact that root NS stuff are now
  included in changes.
@ross ross self-assigned this Jun 4, 2017
@ross ross mentioned this pull request Jun 4, 2017
@ross
Copy link
Contributor Author

ross commented Jun 12, 2017

OK. Looked this over more closely and have done some dry-run testing internally. The behavior seems to be as designed/desired so this is probably ready for thinking/review.

/cc @joewilliams @vanbroup

@ross ross requested a review from joewilliams Jun 12, 2017
@joschi36
Copy link
Contributor

joschi36 commented Dec 10, 2019

any news on this?

@ross
Copy link
Contributor Author

ross commented Dec 10, 2019

@joschi36 IIRC this stalled out when we ran into problems with many/most providers allowing us to manage the root NS records. Specifically that each provider's behavior was different and hard unify. It'd likely require a new provider ability "SUPPORTS_ROOT_NS" etc and even though would get tricky to handle all the edge cases. It may be possible to go through and get everything working in a best effort fashion, but this PR probably isn't sufficient. It's been left here to record the thinking/work.

It'd be nice to have, but unfortunately isn't high on the priorities list.

@joschi36
Copy link
Contributor

joschi36 commented Dec 10, 2019

For us this has high priority as we plan to migrate around 600 zones with multiple octodns repos in github. For us it isn't an option and I'm currently working on a new PR resolving this issue for the providers that support it.

@dchauran
Copy link

dchauran commented Jan 15, 2020

@joschi36 do you have a link to that? My team also needs this.

@basirjamil, @Arunothia FYI

@ross
Copy link
Contributor Author

ross commented Jan 16, 2020

There's some WIP towards this over in #434.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.
X Tutup