Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up@QueryMap does not work with POJOs when used after @Param #852
Comments
|
This is expected. We do not support mixing When using the @RequestLine("GET /things")
CustomPageImpl<ThingDto> getElements(
@QueryMap Map<String, Object> parameters,
@Param(encoder = "PageableEncoder.class") Pageable pageRequest);Add all of your parameters to the map and they will be expanded onto the query string. Using the custom encoder, you can control how the Let me know if this helps or if you have more questions. |
|
I disagree the two models are incompatible, but this should be explicitly stated in the documentation, since as it is written now, what I was trying to do initially should be expected to work. Thanks for your proposed workaround. |
|
Just ran into this, IMO it should be clear in the documentation or even better, the |
|
Time is a friend here. I’ll revisit this. |
Sounds like a good plan @jebeaudet, can you help on making it happen? |


This kind of code (from https://github.com/OpenFeign/feign/pull/335/files#diff-13815c678552a275075ab18b17c67784R616):
Does not work when
@QueryMapis used on a POJO.In my case, I was trying to use Spring's
Pageablelike so:By the way... Is there any simpler way to declare query parameters without having to refer four times to their names?