X Tutup
The Wayback Machine - https://web.archive.org/web/20200709131311/https://github.com/github/VisualStudio/pull/2308
Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing validation display on Create Repository dialog #2308

Merged
merged 5 commits into from Apr 5, 2019
Merged

Fixing validation display on Create Repository dialog #2308

merged 5 commits into from Apr 5, 2019

Conversation

@StanleyGoldman
Copy link
Contributor

StanleyGoldman commented Mar 29, 2019 •
edited

Related #2264

Depends on:

  • #2252 being merged to master

image

image

image

image
@StanleyGoldman
Making use of ValidationMessage controls correctly
Verified
This commit was signed with a verified signature.
StanleyGoldman Stanley Goldman
GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
Loading status checks…
cbff4ef
@StanleyGoldman StanleyGoldman requested a review from jcansdale Mar 29, 2019
@StanleyGoldman
Merge branch 'master' into fixes/repository-creation-view-errors
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0ed0cb9
@StanleyGoldman
Reducing noise in the pull changeset
Verified
This commit was signed with a verified signature.
StanleyGoldman Stanley Goldman
GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
Loading status checks…
b94fb00
@jcansdale
jcansdale reviewed Apr 5, 2019
View changes
src/GitHub.VisualStudio.UI/Views/Dialog/RepositoryCreationView.xaml
@@ -107,17 +107,21 @@
Grid.Column="1"
MaxLength="{x:Static ghfvs:Constants.MaxRepositoryNameLength}"
Text="{Binding RepositoryName, UpdateSourceTrigger=PropertyChanged}"
SpellCheck.IsEnabled="True"

This comment has been minimized.

Sign in to view
Copy link
@jcansdale

jcansdale Apr 5, 2019

Collaborator

It looks like spell checking has been disabled. Was this by design?

This comment has been minimized.

Sign in to view
Copy link
@StanleyGoldman

StanleyGoldman Apr 5, 2019

Author Contributor

Yea, I disabled it, when I couldn't type VisualStudio without it calling that an error, I decided that it was not useful...

This comment has been minimized.

Sign in to view
Copy link
@jcansdale

jcansdale Apr 5, 2019

Collaborator

Lol, makes sense. Though I'm perfectly capable of misspelling the name of my repo. 😉

This comment has been minimized.

Sign in to view
Copy link
@jcansdale

jcansdale Apr 5, 2019

Collaborator

It look like dotcom also has spell checking disabled fro this field.

image

This comment has been minimized.

Sign in to view
Copy link
@Loki777m

Loki777m Jul 22, 2019

ok
@StanleyGoldman
Missing style
Verified
This commit was signed with a verified signature.
StanleyGoldman Stanley Goldman
GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
Loading status checks…
ee33183
@StanleyGoldman
Copy link
Contributor Author

StanleyGoldman commented Apr 5, 2019

Added screenshots
@StanleyGoldman
Merge branch 'master' into fixes/repository-creation-view-errors
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6c261a9
@jcansdale
jcansdale approved these changes Apr 5, 2019
View changes
Copy link
Collaborator

jcansdale left a comment

Looks good. 😄

I tested with the dark theme...
image
@jcansdale jcansdale merged commit 56c347b into master Apr 5, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
github.VisualStudio Build #20190405.21 succeeded
Details
@jcansdale jcansdale deleted the fixes/repository-creation-view-errors branch Apr 5, 2019
@meaghanlewis meaghanlewis mentioned this pull request Apr 5, 2019
Closed
@StanleyGoldman StanleyGoldman added the bug label Apr 11, 2019
@StanleyGoldman StanleyGoldman changed the title Fixing validation on create repository dialog Fixing validation display on Create Repository dialog Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loki777m Loki777m

@jcansdale jcansdale

Assignees
No one assigned
Labels
Ready for Review bug
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@StanleyGoldman @jcansdale @Loki777m
You can’t perform that action at this time.
X Tutup