X Tutup
The Wayback Machine - https://web.archive.org/web/20200706013853/https://github.com/restify/node-restify/issues/1799
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxParamLength Undocumented #1799

Open
jkennedy1980 opened this issue Aug 2, 2019 · 1 comment
Open

maxParamLength Undocumented #1799

jkennedy1980 opened this issue Aug 2, 2019 · 1 comment

Comments

@jkennedy1980
Copy link

@jkennedy1980 jkennedy1980 commented Aug 2, 2019

Bug Report

Restify Version

Documentation ( we're using an old version but the current doc. is still wrong )

Node.js Version

N/A

Expected behaviour

The documentation should explain the maxParamLength

Actual behaviour

The maxParamLength server option should be included in the documentation. It's also a little strange that the server throws a 404 not found when a parameter is too long. It may be better to throw a 400 indicating the issue.

This section details what restify actually did when you ran your code
Server throws a 404 if a route parameter exceeds 100 character ( default in code ).

Cause

That's the way it's written. Just need to update the documentation.

Are you willing and able to fix this?

Sure - where's the documentation? I can submit a code change in the coming weeks if a change is warranted.

@JayeshThamke
Copy link

@JayeshThamke JayeshThamke commented Oct 9, 2019

@jkennedy1980 maxParamLength property is from find-my-way module.
In addition to updating documentation, needs to add specific HTTP return (error) code for example 414 - URI Too Long rather than 404.

regards,
Jayesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.
X Tutup