X Tutup
The Wayback Machine - https://web.archive.org/web/20200628001810/https://github.com/angular/angular/pull/37749
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add lightweight tokens example #37749

Draft
wants to merge 1 commit into
base: master
from

Conversation

@kapunahelewong
Copy link
Contributor

kapunahelewong commented Jun 25, 2020

This commit adds an example app for the lightweight injection tokens documentation to use for snippets. This example includes an Angular app and a library with tree shakable components.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

To do: get it to work 🙃, write e2e tests, add doc regions, and replace hardcoded snippets in doc.

This commit adds an example app for the lightweight injection tokens documentation to use for snippets. This example includes an Angular app and a library with tree shakable components.
@mary-poppins
Copy link

mary-poppins commented Jun 25, 2020

@kapunahelewong kapunahelewong marked this pull request as draft Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.
X Tutup