X Tutup
The Wayback Machine - https://web.archive.org/web/20201218091613/https://github.com/faker-ruby/faker/pull/1980
Skip to content

/ faker

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YARD docs for Faker::Construction #1980

Merged
merged 5 commits into from May 17, 2020
Merged

Add YARD docs for Faker::Construction #1980

merged 5 commits into from May 17, 2020

Conversation

@danielTiringer
Copy link
Contributor

@danielTiringer danielTiringer commented May 14, 2020

Issue#

#1762

Description:

Add complete YARD docs for Faker::Construction methods.
danielTiringer added 2 commits May 14, 2020
danielTiringer
Add YARD docs to Faker::Construction
796f45c
danielTiringer
Add correct faker version
1c45fb6
@koic
koic reviewed May 15, 2020
View changes
lib/faker/default/construction.rb Outdated Show resolved Hide resolved
@koic
koic reviewed May 15, 2020
View changes
lib/faker/default/construction.rb Outdated Show resolved Hide resolved
@koic
koic reviewed May 15, 2020
View changes
lib/faker/default/construction.rb Outdated Show resolved Hide resolved
@koic
koic reviewed May 15, 2020
View changes
lib/faker/default/construction.rb Outdated Show resolved Hide resolved
@koic
koic reviewed May 15, 2020
View changes
lib/faker/default/construction.rb Outdated Show resolved Hide resolved
@koic
koic reviewed May 15, 2020
View changes
lib/faker/default/construction.rb Outdated Show resolved Hide resolved
danielTiringer
correct item order
9be86d2
@koic
koic reviewed May 16, 2020
View changes
lib/faker/default/construction.rb Outdated Show resolved Hide resolved
danielTiringer
remove underscore from description
25ea727
@koic
koic reviewed May 16, 2020
View changes
lib/faker/default/construction.rb Outdated Show resolved Hide resolved
danielTiringer
change another underscore in title
c5d246c
@koic
koic approved these changes May 16, 2020
View changes
@Zeragamba
Zeragamba approved these changes May 17, 2020
View changes
@Zeragamba Zeragamba merged commit 9ef5e27 into faker-ruby:master May 17, 2020
@danielTiringer danielTiringer deleted the danielTiringer:add-construction-docs branch May 17, 2020
@connorshea connorshea mentioned this pull request May 21, 2020
Closed
181 of 181 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koic koic

@Zeragamba Zeragamba

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@danielTiringer @koic @Zeragamba
You can’t perform that action at this time.
X Tutup