X Tutup
The Wayback Machine - https://web.archive.org/web/20201218090819/https://github.com/faker-ruby/faker/pull/1873
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YARD docs for Faker::Music{,::Opera} #1873

Merged
merged 2 commits into from Dec 23, 2019
Merged

Conversation

@jas14
Copy link
Contributor

@jas14 jas14 commented Dec 22, 2019

Issue#

#1762

Description:

Adds YARD docs for Faker::Music and Faker::Music::Opera.

#
# @return [Array<String>]
#
# @faker.version 1.6.4
def keys
%w[C D E F G A B]

This comment has been minimized.

@lucasqueiroz

lucasqueiroz Dec 23, 2019
Member

I know it's not related to your Pull Request, I'm just commenting so we can discuss it :)
Maybe this should become an array inside the localization file or perhaps a constant? (I'd prefer the latter since it probably won't ever change?)

This comment has been minimized.

@jas14

jas14 Dec 23, 2019
Author Contributor

Seems reasonable to me, I'll push another commit to this PR

This comment has been minimized.

@jas14

jas14 Dec 23, 2019
Author Contributor

Oops, seems it's already been merged 🤷‍♂ @lucasqueiroz want me to open another?

This comment has been minimized.

@vbrazo

vbrazo Dec 23, 2019
Member

Yes, you can open a new PR please. Thanks for contributing @jas14

@vbrazo
vbrazo approved these changes Dec 23, 2019
@vbrazo vbrazo merged commit 179ff34 into faker-ruby:master Dec 23, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@connorshea connorshea mentioned this pull request Dec 23, 2019
181 of 181 tasks complete
michebble added a commit to michebble/faker that referenced this pull request Feb 16, 2020
* Add Faker::Music YARD docs

* Add Faker::MUsic::Opera YARD docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.
X Tutup