X Tutup
The Wayback Machine - https://web.archive.org/web/20201218091933/https://github.com/faker-ruby/faker/pull/1810
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yard docs for Faker::Coffee methods #1810

Merged
merged 2 commits into from Nov 11, 2019
Merged

Conversation

@LuanGB
Copy link
Contributor

@LuanGB LuanGB commented Oct 15, 2019

Add yard docs for Faker::Coffee methods

Copy link
Contributor

@connorshea connorshea left a comment

Other than the versions, looks good to me

# @example
# Faker::Coffee.blend_name #=> "Major Java"
#
# @faker.version next

This comment has been minimized.

@connorshea

connorshea Oct 19, 2019
Contributor

The methods for Faker::Coffee were added in 1.8.0, except for intensifier which was added in 1.9.0. All of these should be changed to reflect that.

Copy link
Member

@bpleslie bpleslie left a comment

Looks good other than @connorshea comment. Thanks for the contribution!

@vbrazo
vbrazo approved these changes Nov 11, 2019
Copy link
Member

@vbrazo vbrazo left a comment

👍

@vbrazo vbrazo merged commit fdf95cf into faker-ruby:master Nov 11, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@vbrazo
Copy link
Member

@vbrazo vbrazo commented Nov 11, 2019

@LuanGB welcome!

@connorshea connorshea mentioned this pull request Nov 11, 2019
181 of 181 tasks complete
sanikkenway added a commit to sanikkenway/faker that referenced this pull request Nov 12, 2019
Add yard docs for Faker::Coffee methods (faker-ruby#1810)
michebble added a commit to michebble/faker that referenced this pull request Feb 16, 2020
* Add yard docs for Faker::Coffee methods

* @faker.version should be 1.9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.
X Tutup