X Tutup
The Wayback Machine - https://web.archive.org/web/20201218091942/https://github.com/faker-ruby/faker/pull/1803
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add YARD doc for Faker::Coin #1803

Merged
merged 3 commits into from Nov 14, 2019
Merged

add YARD doc for Faker::Coin #1803

merged 3 commits into from Nov 14, 2019

Conversation

@sap1enza
Copy link
Contributor

@sap1enza sap1enza commented Oct 11, 2019

Issue#

#1762

Description:

Add complete YARD docs for Faker::Coin methods.

Copy link
Contributor

@connorshea connorshea left a comment

Two minor suggestions, other than that it looks good to me. Thanks!

lib/faker/default/coin.rb Outdated Show resolved Hide resolved
lib/faker/default/coin.rb Outdated Show resolved Hide resolved
sap1enza and others added 2 commits Nov 13, 2019
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
@connorshea connorshea mentioned this pull request Nov 13, 2019
181 of 181 tasks complete
Copy link
Contributor

@connorshea connorshea left a comment

LGTM!

@vbrazo
vbrazo approved these changes Nov 14, 2019
Copy link
Member

@vbrazo vbrazo left a comment

Thanks 👍

@vbrazo vbrazo merged commit d8e48fa into faker-ruby:master Nov 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
michebble added a commit to michebble/faker that referenced this pull request Feb 16, 2020
* add coin docs

* Update lib/faker/default/coin.rb

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>

* Update lib/faker/default/coin.rb

Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.
X Tutup