X Tutup
The Wayback Machine - https://web.archive.org/web/20201218092048/https://github.com/faker-ruby/faker/pull/1766
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YARD docs for Faker::Address #1766

Merged
merged 1 commit into from Dec 4, 2019
Merged

Conversation

@connorshea
Copy link
Contributor

@connorshea connorshea commented Sep 29, 2019

This is a pretty big class, so I'm doing it independently of any others.

@connorshea connorshea mentioned this pull request Sep 29, 2019
181 of 181 tasks complete
@vbrazo vbrazo force-pushed the faker-ruby:master branch 3 times, most recently from a2a9f17 to 4384168 Sep 30, 2019
@vbrazo vbrazo force-pushed the faker-ruby:master branch from ace6080 to 4e91448 Oct 10, 2019
@vbrazo vbrazo force-pushed the faker-ruby:master branch from 5a02441 to cc3fbb8 Dec 1, 2019
@connorshea
Copy link
Contributor Author

@connorshea connorshea commented Dec 4, 2019

@vbrazo could I get a review? :)

@vbrazo
vbrazo approved these changes Dec 4, 2019
Copy link
Member

@vbrazo vbrazo left a comment

👍

@connorshea connorshea closed this Dec 4, 2019
@connorshea connorshea reopened this Dec 4, 2019
@vbrazo vbrazo merged commit 035b3aa into faker-ruby:master Dec 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@connorshea connorshea deleted the connorshea:add-address-docs branch Dec 5, 2019
michebble added a commit to michebble/faker that referenced this pull request Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup