X Tutup
The Wayback Machine - https://web.archive.org/web/20200616205201/https://github.com/faker-ruby/faker/issues/1762
Skip to content

/ faker

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete YARD docs #1762

Open
connorshea opened this issue Sep 21, 2019 · 8 comments
Open

Complete YARD docs #1762

connorshea opened this issue Sep 21, 2019 · 8 comments
Labels
good first issue

Comments

@connorshea
Copy link
Contributor

@connorshea connorshea commented Sep 21, 2019 •
edited by Zeragamba

Here are all the Faker classes that have been updated with YARD docs/need to be updated:
@Zeragamba
Copy link
Contributor

@Zeragamba Zeragamba commented Sep 21, 2019

Oh, I love checklists!
@ashishra0
Copy link
Contributor

@ashishra0 ashishra0 commented Oct 4, 2019

Hey @connorshea
Can you please update the checklist? It would be very helpful.
Cheers
@ashishra0 ashishra0 mentioned this issue Oct 4, 2019
Merged
@connorshea connorshea mentioned this issue Oct 8, 2019
Merged
@connorshea
Copy link
Contributor Author

@connorshea connorshea commented Oct 8, 2019

@ashishra0 it should be updated now, I don't check things off until they've been merged into master.
@ashishra0
Copy link
Contributor

@ashishra0 ashishra0 commented Oct 8, 2019

@connorshea Yeah makes sense. Thanks though!
@vbrazo
Copy link
Member

@vbrazo vbrazo commented Oct 8, 2019

That's pretty awesome 💥
@vbrazo vbrazo pinned this issue Oct 8, 2019
This was referenced Oct 11, 2019
Merged
Merged
@vbrazo vbrazo mentioned this issue Nov 2, 2019
Open
This was referenced Dec 5, 2019
Merged
Merged
Merged
Merged
Merged
@jas14 jas14 mentioned this issue Dec 22, 2019
Merged
@Omoyeni663
Copy link

@Omoyeni663 Omoyeni663 commented Jan 2, 2020

I am still in chapter 3 of my course, I need someone to put me through... Better on Twitter @Melebroz1
@ash-elangovan ash-elangovan mentioned this issue Jan 17, 2020
Merged
@kos31de kos31de mentioned this issue Jan 21, 2020
Merged
2 of 2 tasks complete
@michebble michebble mentioned this issue Jan 22, 2020
Closed
@mashuDuek mashuDuek mentioned this issue Mar 17, 2020
Merged
@marientje marientje mentioned this issue Apr 3, 2020
Merged
@rutger-t rutger-t mentioned this issue Apr 4, 2020
Merged
@cubeguerrero cubeguerrero mentioned this issue Apr 8, 2020
Closed
This was referenced May 12, 2020
Merged
Merged
Merged
Merged
This was referenced May 15, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@connorshea
Copy link
Contributor Author

@connorshea connorshea commented May 21, 2020

I've updated the issue description with all the new PRs :)
This was referenced May 21, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@danielTiringer danielTiringer mentioned this issue May 28, 2020
Merged
This was referenced Jun 5, 2020
Merged
Merged
This was referenced Jun 12, 2020
Merged
Merged
Merged
Merged
Merged
@danielTiringer
Copy link
Contributor

@danielTiringer danielTiringer commented Jun 12, 2020

The last one's left is Faker::Code which has an open PR already.
If you want me to complete the Code YARD docs too, please close the existing PR.
@Zeragamba Zeragamba mentioned this issue Jun 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@vbrazo @Zeragamba @connorshea @ashishra0 @danielTiringer @Omoyeni663
You can’t perform that action at this time.
X Tutup