X Tutup
The Wayback Machine - https://web.archive.org/web/20201215063530/https://github.com/github/VisualStudio/issues/2504
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub "Pull Requests" button is confusing by being very similar to the other one #2504

Closed
liviriniu opened this issue Apr 28, 2020 · 2 comments
Closed

Comments

@liviriniu
Copy link

@liviriniu liviriniu commented Apr 28, 2020

Versions

  • GitHub Extension for Visual Studio version: 2.11.96.24460 (probably typo on 2460)
  • Visual Studio version: Community 2019 v16.5.4

What happened

Confusion about what each of the two identically named (and having the same tooltip) "Pull Requests" buttons is exactly for. A distinction is made only through their icons but this is not evident for all the users (especially beginners).
While I was connected only to GitHub, the other button (on the left - see screenshot below), who I understood later that it's for Azure DevOps (TFS) repositories, was not helping me at all understand what is it's purpose - only informed me of the fact that I'm not connected (where? Did not specified). Reconnecting to GitHub obviously changed nothing. I believed maybe the button on the left is also for GitHub but maybe I lack privileges or something to be able to use its associated view/page.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Make sure in Visual Studio you are connected to GitHub but not connected to Azure DevOps (TFS);
  2. In the "Team Explorer" pane -> "Manage Connections" page: Select and open a cloned GitHub repository;
  3. Go to the "Home" page of the "Team Explorer" pane;
  4. See the two identically named (with the same tooltip) PR buttons in the "Project" section.
  5. Also, click the left-side button (the one for Azure DevOps (TFS)) to open its page.
  6. Observe the risk of confusion.

Expected behavior

The button for GitHub pull requests to hint somehow better that it is for GitHub. (Microsoft / Visual Studio teams should clarify this as well with the other button, I think). The icon looks to me as a symbol for merge/pull request and nothing more.

Screenshots

buttons

Logs

Additional context

LE: The counterpart report in Visual Studio Dev Community:

What I was able to find:

@liviriniu liviriniu changed the title GitHub "Pull Requests" button creates confusion being very similar to the other one GitHub "Pull Requests" button is confusing by being very similar to the other one Apr 28, 2020
@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Apr 29, 2020

Thanks for opening the issue and the additional context. I've been in touch with the Visual Studio team and have been told this is going away in a future version. I agree it's confusing!

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Jul 6, 2020

The duplicate Pull Requests button will be going away in a future version of VS. We just need to give it time!

Closing this issue.

@jcansdale jcansdale closed this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.
X Tutup