X Tutup
The Wayback Machine - https://web.archive.org/web/20200529202049/https://github.com/cli/cli/issues/1023
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editing the commit message when squash-merging a PR #1023

Open
g0tsimid opened this issue May 27, 2020 · 0 comments
Open

Allow editing the commit message when squash-merging a PR #1023

g0tsimid opened this issue May 27, 2020 · 0 comments
Labels

Comments

@g0tsimid
Copy link

@g0tsimid g0tsimid commented May 27, 2020

Describe the feature or problem you’d like to solve

When performing a squash and merge on a pull request through the web interface, you can edit the commit message and extended description. By default, this is prepopulated with a list of all of the commit messages included in the pull request. I often find myself deleting some of the lines from this section because the additional commits are usually related to feedback brought up during the code review, and would be irrelevant or confusing when viewing in the context of the final commit.

When merging a PR through the CLI, the same commit message is generated as the web interface, but there is no option to edit the commit message.

Proposed solution

Open the user's default terminal editor to allow the PR maintainer to enter the commit message. By default, prepopulate the editor with the default generated message so the user can easily just save and exit the editor to continue using the current behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.
X Tutup