X Tutup
The Wayback Machine - https://web.archive.org/web/20200130105427/https://github.com/python/cpython/pull/18278
Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38631: Add _Py_NO_RETURN to functions calling Py_FatalError() #18278

Open
wants to merge 1 commit into
base: master
from
Open

bpo-38631: Add _Py_NO_RETURN to functions calling Py_FatalError() #18278

wants to merge 1 commit into from
+12 −29

Conversation

@vstinner
Copy link
Member

vstinner commented Jan 30, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue38631
@vstinner vstinner added the skip news label Jan 30, 2020
@vstinner vstinner requested a review from rhettinger as a code owner Jan 30, 2020
@vstinner

This comment has been minimized.

Sign in to view
Copy link
Member Author

vstinner commented Jan 30, 2020

About clang "code will never be executed [-Wunreachable-code]" warning: I compiled Python using clang -O3. There is one warning, but it's unrelated to this change:

./Modules/timemodule.c:113:13: warning: code will never be executed [-Wunreachable-code]

I tested clang version 9.0.0 (Fedora 9.0.0-1.fc31).
@vstinner
bpo-38631: Add _Py_NO_RETURN to functions calling Py_FatalError()
Loading status checks…
4102725
@vstinner vstinner force-pushed the vstinner:noreturn branch from fda3f27 to 4102725 Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger

Assignees
No one assigned
Labels
CLA signed awaiting core review skip news
Projects
None yet
Milestone
No milestone
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.
X Tutup