X Tutup
The Wayback Machine - https://web.archive.org/web/20200917205826/https://github.com/nodejs/docker-node/pull/1173
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update contributing to mentions security yarn releases #1173

Merged
merged 1 commit into from Jan 2, 2020

Conversation

@SimenB
Copy link
Member

SimenB commented Dec 18, 2019

@PeterDaveHello brought up a great point in #1170 (comment) - our current policy states that we only update yarn when there's new releases of node. I somewhat regret just moving on instead of backing out those changes and discussing. However, I think we should update it on security updates, so here's a PR with a policy update

@SimenB SimenB requested a review from nodejs/docker Dec 18, 2019
@LaurentGoderre
Copy link
Contributor

LaurentGoderre commented Dec 19, 2019

I am not familiar with their process but only the security patch should be applied an the major and minor version should stay the same, if possible.

@PeterDaveHello
Copy link
Member

PeterDaveHello commented Dec 19, 2019

cc @nodejs/docker

BTW, any other teams we should also mention/tag?

@PeterDaveHello
Copy link
Member

PeterDaveHello commented Dec 19, 2019

I believe that @tianon could also give us some valuable input.

@tianon
Copy link
Contributor

tianon commented Dec 31, 2019

Many other images perform even minor component updates within the same patch release of their primary software, but regardless I think generally that security updates are always a good candidate for process exceptions since that typically matches the expectations of the majority of users (in other words, users will typically expect to get security updates as quickly as possible, regardless of the non-security-updates process).

@SimenB
Copy link
Member Author

SimenB commented Dec 31, 2019

Thanks @tianon, that matches what I've seen (and my own expectation) as well

@PeterDaveHello PeterDaveHello merged commit 3951ce4 into master Jan 2, 2020
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@PeterDaveHello PeterDaveHello deleted the SimenB-patch-1 branch Jan 2, 2020
@PeterDaveHello
Copy link
Member

PeterDaveHello commented Jan 2, 2020

Let's get this done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.
X Tutup