X Tutup
The Wayback Machine - https://web.archive.org/web/20200918094857/https://github.com/PowerShell/PSScriptAnalyzer/pull/1197
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logic for copying profiles into the 'install' directory #1197

Merged
merged 1 commit into from Mar 27, 2019

Conversation

@JamesWTruher
Copy link
Member

JamesWTruher commented Mar 26, 2019

PR Summary

Multiple runs would result in an incorrect layout of the compatibility profiles
The problem did not exist in our CI/Release system as those are clean environments. This problem only exists if you run build multiple times.

PR Checklist

Multiple runs would result in incorrect layout of the compatibility profiles
@JamesWTruher JamesWTruher requested a review from bergmeister Mar 26, 2019
Copy link
Collaborator

bergmeister left a comment

Looks, OK, I am happy to close my alternative PR #1190 in favour of this. This brings back memories about PowerShell's iffy behaviour of Copy-Item (the behaviour is different depending on whether the target location exists)

@bergmeister bergmeister merged commit cc75c62 into PowerShell:development Mar 27, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup