X Tutup
The Wayback Machine - https://web.archive.org/web/20210119191330/https://github.com/realpython/python-guide/pull/997
Skip to content

/ python-guide

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc website] Update the search experience #997

Merged
merged 2 commits into from Apr 23, 2019
Merged

[doc website] Update the search experience #997

merged 2 commits into from Apr 23, 2019

Conversation

@s-pace
Copy link
Contributor

@s-pace s-pace commented Apr 23, 2019 •
edited

👋 team,

TL;DR: Enhance the search experience as https://pipenv.readthedocs.io/en/latest/

This PR:

  • Enables async way of loading assets. It will avoid any perf issue.
  • Add the search to every pages.

Let me know if you need anything
s-pace added 2 commits Apr 23, 2019
s-pace
feat: enhance search to the main introduction page
b08cf0c
s-pace
feat: add search to every documentation pages
Loading status checks…
f43eff5
@dbader
Copy link
Member

@dbader dbader commented Apr 23, 2019

Cheers @s-pace, works like a charm :) LGTM
@dbader dbader merged commit b4da9ce into realpython:master Apr 23, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@dojutsu-user dojutsu-user mentioned this pull request May 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@s-pace @dbader
You can’t perform that action at this time.
X Tutup