X Tutup
The Wayback Machine - https://web.archive.org/web/20190412214638/https://github.com/nodejs/node/commit/c688a00a6d
Skip to content
Permalink
Browse files

build: fix 'gas_version' check on localized environments

Some GNU assembler versions got localized outputs like...

```
Gnu assembler versão 2.30 (x86_64-linux-gnu) usando versão BFD (GNU Binutils for Ubuntu) 2.30
```

failing regex checker and the whole configure process.

PR-URL: #20394
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
oliveiraev authored and targos committed Apr 29, 2018
1 parent 4757771 commit c688a00a6d4277bc98e7ae3d8bbdb7cbacd2cad2
Showing with 3 additions and 1 deletion.
  1. +3 −1 configure
@@ -671,11 +671,13 @@ def get_xcode_version(cc):

def get_gas_version(cc):
try:
custom_env = os.environ.copy()
custom_env["LC_ALL"] = "en_US"
proc = subprocess.Popen(shlex.split(cc) + ['-Wa,-v', '-c', '-o',
'/dev/null', '-x',
'assembler', '/dev/null'],
stdin=subprocess.PIPE, stderr=subprocess.PIPE,
stdout=subprocess.PIPE)
stdout=subprocess.PIPE, env=custom_env)
except OSError:
error('''No acceptable C compiler found!

0 comments on commit c688a00

Please sign in to comment.
You can’t perform that action at this time.
X Tutup