X Tutup
The Wayback Machine - https://web.archive.org/web/20210119191426/https://github.com/realpython/python-guide/pull/953
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "caller" instead of "global" to describe where imports go #953

Merged
merged 1 commit into from Dec 28, 2018

Conversation

@apjanke
Copy link
Contributor

@apjanke apjanke commented Dec 17, 2018

This passage talks about import copying names into the global namespace. But doesn't it copy names into the calling module's namespace instead?

@mpoulin
Copy link
Contributor

@mpoulin mpoulin commented Dec 27, 2018

@apjanke I don't like the word caller because you don't call a module in the sense of calling a function or class method. What about saying "the local namespace" instead? That matches the terminology used in the official Python docs.

@apjanke apjanke force-pushed the apjanke:global-vs-caller-namespace branch from 345999f to d012a66 Dec 27, 2018
@apjanke
Copy link
Contributor Author

@apjanke apjanke commented Dec 27, 2018

Yes, that makes sense.

I've updated this PR to do that.

@mpoulin mpoulin merged commit 979b4cd into realpython:master Dec 28, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@apjanke apjanke deleted the apjanke:global-vs-caller-namespace branch Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup