X Tutup
The Wayback Machine - https://web.archive.org/web/20201206081221/https://github.com/MagicStack/MagicPython/issues/132
Skip to content

/ MagicPython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpacking Arguments not detected on new lines #132

Closed
gtalarico opened this issue Apr 27, 2018 · 5 comments
Closed

Unpacking Arguments not detected on new lines #132

gtalarico opened this issue Apr 27, 2018 · 5 comments
Assignees
@vpetrovykh
Labels
bug

Comments

@gtalarico
Copy link

@gtalarico gtalarico commented Apr 27, 2018 •
edited by 1st1

  • Editor name and version: VS Code 1.22.2
  • Platform: MacOs 10.13
  • Color scheme: Monokai w/ Custom
  • MagicPython version: The one shipped with VS Code 1.22.2. Commit:
    "b453f26"

Actual behavior

keyword.operator.unpacking.arguments.python is not detected on a new line

Expected behavior

Should be detected in new lines

Steps to reproduce:

some_long_line_________________________________________ = foo('a', 'b', *items, **kwargs)
# In this case, *items is detected properly

some_long_line_________________________________________ = foo('a', 'b'
                                                              *items,
                                                              **kwargs)
# here, both arg and kwargs are not detected properkly

Screenshot

image

Scope - Correct

image

Scope - Incorrect

image
@1st1
Copy link
Member

@1st1 1st1 commented Apr 27, 2018

You're missing a comma in your second example.
@1st1
Copy link
Member

@1st1 1st1 commented Apr 27, 2018

A comma before *items
@gtalarico
Copy link
Author

@gtalarico gtalarico commented Apr 27, 2018

You are right I missed a comma on the example but that was just a terrible coincidence :)
The issue is still present

image
@1st1
Copy link
Member

@1st1 1st1 commented Apr 27, 2018

@vpetrovykh
@1st1 1st1 added the bug label May 17, 2018
vpetrovykh added a commit that referenced this issue Jul 20, 2018
@vpetrovykh
Update the `*` and `**` in funciton call scopes.
Loading status checks…
ad6bd62 
Use `keyword.operator.unpacking.arguments.python` more consistently.

Issue #132.
@1st1
Copy link
Member

@1st1 1st1 commented Oct 4, 2018

The fixed version will be released soon!
@1st1 1st1 closed this Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vpetrovykh vpetrovykh

Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@1st1 @vpetrovykh @gtalarico and others
You can’t perform that action at this time.
X Tutup