Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Make Travis CI use libcurl+openssl+gssapi for macOS #5629
Conversation
markekraus
added
the
Documentation Needed
label
Dec 5, 2017
markekraus
requested review from
adityapatwardhan,
daxian-dbw and
TravisEz13
as
code owners
Dec 5, 2017
markekraus
changed the title from
Make Travis CI use libcurl+openssl
to
Make Travis CI use libcurl+openssl+gssapi
Dec 5, 2017
|
yay.. all passed this time. So.. the question is where do I document this at? in the web cmdlets documentations? somewhere in this repo (install documentation)? both? |
|
We need to document it in the web cmdlets help content, and point out what parameters are affected by this. |
markekraus
added some commits
Dec 5, 2017
TravisEz13
approved these changes
Dec 6, 2017
One comment about another issue this PR brings up, Please file an issue or submit a PR for this and link in this PR.
| @@ -5,6 +5,8 @@ | ||
| - Update the contribution guideline to note that updating the changelog is required. (#5586) | ||
| - Remove Pester as a module include with the PowerShell Packages. | ||
| In the future, you should be able to add it by running `Install-Module Pester`. (#5623, #5631) | ||
| +- Make Travis CI use `libcurl+openssl` (#5629, @markekraus) | ||
| +- Make Travis CI use `libcurl+openssl+gssapi` (#5629, @markekraus) |
| @@ -1533,7 +1533,7 @@ function Start-PSBootstrap { | ||
| Start-NativeExecution { brew install $Deps } -IgnoreExitcode | ||
| # Install patched version of curl | ||
| - Start-NativeExecution { brew install curl --with-openssl } -IgnoreExitcode | ||
| + Start-NativeExecution { brew install curl --with-openssl --with-gssapi } -IgnoreExitcode |
TravisEz13
Dec 6, 2017
Member
We should update the PowerShell brew recipe as well.
https://github.com/caskroom/homebrew-cask/blob/master/Casks/powershell.rb#L33
daxian-dbw
Dec 6, 2017
Member
We need to figure out what to do with the powershell package about this limitation on macOS.
CoreCLR has explicitly moved away from OpenSSL on mac, see this PR: dotnet/corefx#17011.
Please open an issue to track the macOS packaging about this.
daxian-dbw
self-assigned this
Dec 6, 2017
This was referenced Dec 6, 2017
|
I didn't add the [feature] tag when resolving a conflict. Add the |
daxian-dbw
merged commit ee7fbed
into
PowerShell:master
Dec 6, 2017
daxian-dbw
changed the title from
Make Travis CI use libcurl+openssl+gssapi
to
Make Travis CI use libcurl+openssl+gssapi for macOS
Dec 6, 2017
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Dec 7, 2017
added a commit
that referenced
this pull request
Dec 7, 2017
markekraus commentedDec 5, 2017
•
Edited 4 times
-
markekraus
Dec 5, 2017
-
markekraus
Dec 5, 2017
-
markekraus
Dec 5, 2017
-
markekraus
Dec 5, 2017
Closes #5590
brewinstalledlibcurlthat uses OpenSSL for the crypto provider and include the gssapi option. The native libcurl provides inconsistent feature support across OS versions.PowerShellGetin order to supportHttpClientHandler.UseDefaultCredentialswhich it sets as true (unless you supply credentials).PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affectes feature testsPR Summary