Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Update PowerShell to build with .NET Core 2.0.5 #5903
Conversation
iSazonov
assigned
daxian-dbw
Jan 15, 2018
iSazonov
requested a review
from
daxian-dbw
Jan 15, 2018
iSazonov
requested review from
adityapatwardhan and
TravisEz13
as
code owners
Jan 15, 2018
|
Pleas push a commit with |
|
Do we need to mention the 2 important security fixes that come with 2.0.5 in the documents? Can someone review their severity/impact and decide whether this also means that 6.0 needs to have a patch with this update? @LeeHolmes |
| @@ -2,7 +2,7 @@ | ||
| image: Visual Studio 2017 | ||
| -# cache version - netcoreapp.2.0.4 | ||
| +# cache version - netcoreapp.2.0.5 |
bergmeister
Jan 15, 2018
•
Contributor
Do we need to drop one of the caches (maybe in a separate PR)? I have seen recently that we always hit the 1GB limit of AppVeyor where it tries to upload it but then fails.
|
Should we also update the SDK in the global.json from |
|
I think could we move to latest SDK (2.1.4) after GA 6.0.1 to get up to date the 6.0.0 servicing branch. Interesting, will we be able to move to CoreFX 2.1.0 preview version in our development branch - this version already contains many performance improvements and we could use new C# 7.2. |
daxian-dbw
requested a review
from
PaulHigin
Jan 16, 2018
|
@LeeHolmes @PaulHigin @SteveL-MSFT can you please take a look at the comment #5903 (comment) and see if there's any implication on PS Core 6.0.0? |
TravisEz13
merged commit 89bdb17
into
PowerShell:master
Jan 17, 2018
|
We should take dotnetcore 2.0.5 as part of 6.0.1 release |
iSazonov
deleted the
iSazonov:update-dotnetcore-2.0.5
branch
Jan 17, 2018
|
@SteveL-MSFT OK. On a related note: The WiX toolset also had a security patch 2 weeks ago: https://www.firegiant.com/blog/2017/12/31/wix-v3.10.4-and-wix-v3.11.1-released/ |
|
It seems we use WiX from AppVeyor base image - so the issue is for AppVeyor. |
|
Yes, but I guess that MSFT uses their own servers for building the GA release. This was a remark about the upcoming patch release. |
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Jan 17, 2018
This was referenced Jan 17, 2018
added a commit
that referenced
this pull request
Jan 17, 2018
TravisEz13
added this to the 6.0.1 milestone
Jan 18, 2018
|
@iSazonov @SteveL-MSFT I am confused, the global.json still refers to |


iSazonov commentedJan 15, 2018
•
Edited 1 time
-
iSazonov
Jan 15, 2018
PR Summary
Use new .Net Core servicing build 2.0.5.
https://github.com/dotnet/cli/releases
https://blogs.msdn.microsoft.com/dotnet/2018/01/09/net-core-january-2018-update/
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affects feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.