Update PowerShell to build with .NET Core 2.0.5 #5903

Merged
merged 1 commit into from Jan 17, 2018

Conversation

Projects
None yet
6 participants
Collaborator

iSazonov commented Jan 15, 2018

PR Summary

Use new .Net Core servicing build 2.0.5.
https://github.com/dotnet/cli/releases
https://blogs.msdn.microsoft.com/dotnet/2018/01/09/net-core-january-2018-update/

PR Checklist

Note: Please mark anything not applicable to this PR NA.

@iSazonov iSazonov requested a review from daxian-dbw Jan 15, 2018

Collaborator

markekraus commented Jan 15, 2018

Pleas push a commit with [Feature] in the commit message.

Contributor

bergmeister commented Jan 15, 2018

Do we need to mention the 2 important security fixes that come with 2.0.5 in the documents?

Can someone review their severity/impact and decide whether this also means that 6.0 needs to have a patch with this update? @LeeHolmes

@@ -2,7 +2,7 @@
image: Visual Studio 2017
-# cache version - netcoreapp.2.0.4
+# cache version - netcoreapp.2.0.5
@bergmeister

bergmeister Jan 15, 2018

Contributor

Do we need to drop one of the caches (maybe in a separate PR)? I have seen recently that we always hit the 1GB limit of AppVeyor where it tries to upload it but then fails.

@markekraus

markekraus Jan 15, 2018

Collaborator

touching the appveory.yml should cause the cache to rebuild.

Contributor

bergmeister commented Jan 15, 2018

Should we also update the SDK in the global.json from 2.0.2 to 2.0.3, which is already in the used AppVeyor image VisualStudio2017?

Collaborator

iSazonov commented Jan 16, 2018

I think could we move to latest SDK (2.1.4) after GA 6.0.1 to get up to date the 6.0.0 servicing branch.

Interesting, will we be able to move to CoreFX 2.1.0 preview version in our development branch - this version already contains many performance improvements and we could use new C# 7.2.

@daxian-dbw daxian-dbw requested a review from PaulHigin Jan 16, 2018

Member

daxian-dbw commented Jan 16, 2018

@LeeHolmes @PaulHigin @SteveL-MSFT can you please take a look at the comment #5903 (comment) and see if there's any implication on PS Core 6.0.0?

@TravisEz13 TravisEz13 merged commit 89bdb17 into PowerShell:master Jan 17, 2018

4 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
Owner

SteveL-MSFT commented Jan 17, 2018

We should take dotnetcore 2.0.5 as part of 6.0.1 release

@iSazonov iSazonov deleted the iSazonov:update-dotnetcore-2.0.5 branch Jan 17, 2018

Contributor

bergmeister commented Jan 17, 2018

@SteveL-MSFT OK. On a related note: The WiX toolset also had a security patch 2 weeks ago: https://www.firegiant.com/blog/2017/12/31/wix-v3.10.4-and-wix-v3.11.1-released/

Collaborator

iSazonov commented Jan 17, 2018

It seems we use WiX from AppVeyor base image - so the issue is for AppVeyor.

Contributor

bergmeister commented Jan 17, 2018

Yes, but I guess that MSFT uses their own servers for building the GA release. This was a remark about the upcoming patch release.

TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request Jan 17, 2018

TravisEz13 added a commit that referenced this pull request Jan 17, 2018

@TravisEz13 TravisEz13 added this to the 6.0.1 milestone Jan 18, 2018

Contributor

bergmeister commented Jan 20, 2018

@iSazonov @SteveL-MSFT I am confused, the global.json still refers to 2.0.2 and the documentation on it here says that this is the SDK (not the runtime version). This SDK version contains the old 2.0.0. version of the .Net Runtime, see docs here
Do we not need to update the string to 2.1.4, which is the SDK containing the 2.0.5 runtime, see docs here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment