- Remove unnecessary/unused default for productGuid because it always…
… gets a new Guid when being called from `Start-PSPackage` - Add defaults for required files but also add extra path validation attribute - Rename ProductGuid to ProductCode

… gets a new Guid when being called from `Start-PSPackage` - Add defaults for required files but also add extra path validation attribute - Rename ProductGuid to ProductCode
address PR comments (missing "product guid" -> "product code" renamin…
…g in comments) and use the word repo instead of checkout in comment to be more clear.
PowerShell · TravisEz13 · Jan 17, 2018 · bergmeister · Jan 11, 2018 · bergmeister
diff --git a/build.psm1 b/build.psm1
+        This only works on a Windows machine due to the usage of WiX.
+    .EXAMPLE
+        # This example shows how to produce a Debug-x64 installer for development purposes.
+        cd $RootPathOfPowerShellCheckout
diff --git a/build.psm1 b/build.psm1
@@ -2070,8 +2080,9 @@ function New-MSIPackage
         [string] $ProductVersion,
 
         # Product Guid needs to change for every version to support SxS install
diff --git a/tools/packaging/packaging.psm1 b/tools/packaging/packaging.psm1
@@ -243,7 +243,7 @@ function Start-PSPackage {
                     AssetsPath = "$PSScriptRoot\..\..\assets"
                     LicenseFilePath = "$PSScriptRoot\..\..\assets\license.rtf"
                     # Product Guid needs to be unique for every PowerShell version to allow SxS install
diff --git a/build.psm1 b/build.psm1
@@ -2069,9 +2079,10 @@ function New-MSIPackage
         [ValidateNotNullOrEmpty()]
         [string] $ProductVersion,
 
-        # Product Guid needs to change for every version to support SxS install
+        # Product Code needs to change for every version to support SxS install
diff --git a/tools/packaging/packaging.psm1 b/tools/packaging/packaging.psm1
@@ -242,8 +242,8 @@ function Start-PSPackage {
                     ProductVersion = $Version
                     AssetsPath = "$PSScriptRoot\..\..\assets"
                     LicenseFilePath = "$PSScriptRoot\..\..\assets\license.rtf"
-                    # Product Guid needs to be unique for every PowerShell version to allow SxS install
-                    ProductGuid = New-Guid
+                    # Product Code needs to be unique for every PowerShell version to allow SxS install
diff --git a/assets/Product.wxs b/assets/Product.wxs
@@ -5,7 +5,7 @@
   <!-- TBD:Point to the actual release -->
   <?define InfoURL="https://github.com/PowerShell/PowerShell" ?>
   <?define ProductName = "$(env.ProductName)" ?>
-  <?define ProductGuid = "$(env.ProductGuid)" ?>
+  <?define ProductCode = "$(env.ProductCode)" ?>
   <!-- UpgradeCode GUID MUST REMAIN SAME THROUGHOUT ALL VERSIONS, otherwise, updates won't occur. -->