Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add PowerShell VSCode style settings #5529
Conversation
bergmeister
added some commits
Nov 22, 2017
bergmeister
referenced this pull request
Nov 22, 2017
Merged
remove `signed` folder in zip after copying signed binaries for packaging #5527
|
When I last touched that file I considered adding these settings but I noticed that the PowerShell script in this repo is not terribly consistent style-wise. I like the idea of it being more consistent but this PR would make it easier for folks using VSCode to mix semantic changes with style changes. I wonder if it would be better to just take the "styling" hit once and make all the script files conform to this style setup? |
|
One could apply the styling to the files since VSCode has the |
SteveL-MSFT
assigned
daxian-dbw
Nov 27, 2017
SteveL-MSFT
requested a review
from
daxian-dbw
Nov 27, 2017
|
I'm fine with the proposed setting changes. We can apply the style universally after GA. |


bergmeister commentedNov 22, 2017
Add the following VS Code settings to have a more consistent
PowerShellstyle already at the PR stage. It is mainly based on the K&R/OTBS style, which basically means braces are on the same line and that else, catch, and other keywords are "cuddled" (e.g.} else {)Personally I'd prefer rather the Stroustrup style where there is no "cuddling" but I have seen that the
K&R/OTBSis used more often in the codebase.