Export PSReadLine to changes to public project #996

Closed
andschwa opened this Issue May 18, 2016 · 6 comments

Comments

Projects
None yet
6 participants
Member

andschwa commented May 18, 2016

This is just so I remember to do this for @lzybkr.

@andschwa andschwa added this to the v0.5.0 milestone May 18, 2016

@andschwa andschwa self-assigned this May 18, 2016

@andschwa andschwa modified the milestones: v0.5.0, v0.6.0 Jun 8, 2016

Member

andschwa commented Jun 24, 2016

While extracting the history and making PSReadLine build stand-alone against the public reference assemblies, I got blocked by a weird .NET possible bug. Filed dotnet/corefx#9658.

@andschwa andschwa modified the milestones: Aug17, v0.6.0, Future Jun 29, 2016

@andschwa andschwa referenced this issue in lzybkr/PSReadLine Sep 16, 2016

Closed

Import PowerShell changes #442

Member

andschwa commented Sep 19, 2016

Changes have been exported, closing.

@andschwa andschwa closed this Sep 19, 2016

@lzybkr lzybkr reopened this Sep 19, 2016

Member

lzybkr commented Sep 19, 2016

This shouldn't be closed until PSReadline has a single source of truth.

  • Changes are accepted
  • Package from lzybkr/PSReadline are being consumed here
  • PSReadline sources are removed from this repo
Member

andschwa commented Sep 19, 2016

Okay, well I'm at least changing over the assignee then.

@andschwa andschwa assigned lzybkr and unassigned andschwa Sep 19, 2016

@HemantMahawar HemantMahawar modified the milestones: 6.0.0, post-6.0.0 Oct 17, 2016

@joeyaiello joeyaiello modified the milestones: 6.1.0, 6.0.0 May 22, 2017

lzybkr added a commit to lzybkr/PowerShell that referenced this issue Dec 29, 2017

Pull PSReadLine from PSGallery
Instead of building PSReadLine from this repo, pull it from the gallery.

Fix #996

@lzybkr lzybkr removed the Blocked label Dec 29, 2017

@lzybkr lzybkr referenced this issue Dec 29, 2017

Merged

Pull PSReadLine from PSGallery #5759

8 of 9 tasks complete

lzybkr added a commit to lzybkr/PowerShell that referenced this issue Dec 29, 2017

Pull PSReadLine from PSGallery
Instead of building PSReadLine from this repo, pull it from the gallery.

Fix #996

lzybkr added a commit to lzybkr/PowerShell that referenced this issue Jan 8, 2018

Pull PSReadLine from PSGallery
Instead of building PSReadLine from this repo, pull it from the gallery.

Fix #996

lzybkr added a commit to lzybkr/PowerShell that referenced this issue Jan 8, 2018

Pull PSReadLine from PSGallery
Instead of building PSReadLine from this repo, pull it from the gallery.

Fix #996

@TravisEz13 TravisEz13 closed this in #5759 Jan 20, 2018

TravisEz13 added a commit that referenced this issue Jan 20, 2018

Pull PSReadLine from PSGallery (#5759)
Instead of building PSReadLine from this repo, pull it from the gallery using nuget cache.

This pulls v2.0 of PSReadLine which does have documented breaking changes from v1.2, but the risk is small - the features that have changed are typically only used in a profile and aren't used all that often anyway.

Fix #996

Hardcodes version of modules pulled from PSGallery
Contributor

it-praktyk commented Jan 20, 2018

After this change, the easiest way to pull the Pester module from PowerShell Gallery is to add it to the file src/Modules/PSGalleryModules.csproj but as the result,

  • Pester module will be pulled every time
  • the switch CI used in the functions
    • Start-PSBuild
    • Restore-PSModuleToBuild
      will be useless and have to be removed.

Another option - probably a more accurate - is to create the new one csproj file - by analogy to src/Modules/PSGalleryModules.csproj (the proposed name PSGalleryModulesCI.csproj) and add an additional parameter to the function Copy-PSGalleryModules that will contain a path to csproj file (an equivalent of the current line 2484) and call the function Copy-PSGalleryModules twice when $CI will be used.

In both options the functions

What do you think? Am I right?

My comment is related to #4618.

Member

lzybkr commented Jan 21, 2018

@it-praktyk - msbuild restore caches the package locally, so if the cache already has the correct version, nothing is pulled.

Furthermore, at least in AppVeyor (I'm not sure about Travis) - the cache is saved across builds, so we shouldn't see too many pulls from CI.

I think what I did for PSReadLine can be done for Pester as well and as you point out - that would get rid of some code in build.psm1 - but I haven't looked as closely as you - maybe we don't need the -CI parameter assuming the nuget cache is working as I described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment