Fix remaining text files stored with CRLF line endings in the tree. #18
Conversation
|
My concern with patch files is because I've seen the patch tool refuse to apply things that had the wrong line endings. As usual, the Windows version seems to be lenient and allow CRLF or LF, while the Unix version will choke on CRs. |
…rce CRLF line endings for them.
|
If you do a clean checkout, are the files correct then? |
|
@learn-more: Yes |
HBelusca
added a commit
to HBelusca/reactos
that referenced
this pull request
Oct 7, 2017
Based on https://stackoverflow.com/a/1511273 Also enforce CRLF for all *.xml files in our tree, because they are distributed with ReactOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
@gigaherz and @yagoulas found out that our Git still stores some text files internally with CRLF line endings, although all should be stored as LF and only checked out as defined in .gitattributes.
Based on https://stackoverflow.com/a/1511273, I have done another attempt to fix the remaining line endings.
Note that this also touches .diff/.patch files. @ThFabba had his doubts about changing line endings in patch files. As we check out our source files with OS-native line endings though, I think the same should apply for the corresponding patch files.