X Tutup
The Wayback Machine - https://web.archive.org/web/20260219013530/https://github.com/python/cpython/pull/1129
Skip to content

improve alignment autoconf test#1129

Merged
benjaminp merged 1 commit intomasterfrom
benjamin-aligned-autoconf
Apr 14, 2017
Merged

improve alignment autoconf test#1129
benjaminp merged 1 commit intomasterfrom
benjamin-aligned-autoconf

Conversation

@benjaminp
Copy link
Contributor

Replace the deprecated AC_TRY_RUN with AC_RUN_IFELSE. Also, standardize the
variable name and allow for caching of the result.

Replace the deprecated AC_TRY_RUN with AC_RUN_IFELSE. Also, standardize the
variable name and allow for caching of the result.
docdir
oldincludedir
includedir
runstatedir
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part already was added and then removed back because this was a feature from still not released autoconf version. What version do you use? Is it already released?

Copy link
Contributor

@louisom louisom Apr 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what I know, autoconf is now current at 2.69, and have no plan for new version release*.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is from the autoconf that Ubuntu ships. I don't really see the harm in having the --runstatedir option around.

@serhiy-storchaka
Copy link
Member

@benjaminp benjaminp merged commit e4f961b into master Apr 14, 2017
@benjaminp benjaminp deleted the benjamin-aligned-autoconf branch April 14, 2017 16:36
benjaminp added a commit that referenced this pull request Apr 14, 2017
Replace the deprecated AC_TRY_RUN with AC_RUN_IFELSE. Also, standardize the
variable name and allow for caching of the result.
benjaminp added a commit that referenced this pull request Apr 14, 2017
Replace the deprecated AC_TRY_RUN with AC_RUN_IFELSE. Also, standardize the
variable name and allow for caching of the result.
@serhiy-storchaka
Copy link
Member

@benjaminp
Copy link
Contributor Author

The discussion seems inconclusive. I still think we should stop checking generated files in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments

X Tutup