bpo-29196: Removed old-deprecated classes Plist, Dict and _InternalDict#488
Merged
serhiy-storchaka merged 7 commits intopython:masterfrom May 15, 2017
Conversation
in the plistlib module. Dict values in the result of functions readPlist() and readPlistFromBytes() are now exact dicts.
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ronaldoussoren, @tiran, @ned-deily, @birkenfeld and @jackjansen to be potential reviewers. |
Doc/library/plistlib.rst
Outdated
|
|
||
| .. deprecated:: 3.4 Use :func:`load` instead. | ||
|
|
||
| .. versionchanged: 3.7 |
Doc/library/plistlib.rst
Outdated
| .. deprecated:: 3.4 Use :func:`load` instead. | ||
|
|
||
| .. versionchanged: 3.7 | ||
| Dict values in the result are now exact dicts. |
Member
There was a problem hiding this comment.
It would be better if we could mention the previous behavior (dicts with a __getattr__ method) too.
Doc/whatsnew/3.7.rst
Outdated
| Python 3.1, and has now been removed. Use the :func:`~os.path.splitdrive` | ||
| function instead. | ||
|
|
||
| * Removed old-deprecated classes ``Plist``, ``Dict`` and ``_InternalDict`` |
Member
There was a problem hiding this comment.
"Removed previously deprecated [...]"
Member
There was a problem hiding this comment.
This is pretty minor, but perhaps we can add Python versions too:
- ``Dict`` (deprecated in Python 3.0)
- ``Dict`` (Python 3.0)
…b-remove-deprecated-classes
….com:serhiy-storchaka/cpython into bpo-29196-plistlib-remove-deprecated-classes
auvipy
approved these changes
Apr 22, 2017
Contributor
ronaldoussoren
left a comment
ronaldoussoren
left a comment
There was a problem hiding this comment.
LGTM, other than a trivial issue in a test case.
Lib/test/test_plistlib.py
Outdated
| data = plistlib.dumps(pl) | ||
| pl2 = plistlib.loads(data) | ||
| self.assertNotIsInstance(pl, plistlib._InternalDict) | ||
| self.assertEqual(pl, pl2) |
Contributor
There was a problem hiding this comment.
This is basically the same assertion as in the next line.
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.4.1 to 1.4.3. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-python@1.4.1...1.4.3) --- updated-dependencies: - dependency-name: sentry-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the plistlib module. Dict values in the result of functions
readPlist() and readPlistFromBytes() are now exact dicts.