[WIP] bpo-30198: distutils: call os.stat() in serial#1342
Closed
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:test_extension
Closed
[WIP] bpo-30198: distutils: call os.stat() in serial#1342vstinner wants to merge 1 commit intopython:masterfrom vstinner:test_extension
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:test_extension
Conversation
Modify the build_ext of distutils to call newer_group() in serial mode even if the parallel mode is used, instead of calling newer_group() in threads, to avoid a slowdown caused by the GIL on os.stat(). Benchmark with 4 logical CPUs (2 physical cores) on "./python -E ./setup.py build": +-----------+----------+-----------------------------+ | Benchmark | ref | patch | +===========+==========+=============================+ | -j4 | 1.06 sec | 576 ms: 1.84x faster (-46%) | +-----------+----------+-----------------------------+ | -j16 | 1.01 sec | 583 ms: 1.73x faster (-42%) | +-----------+----------+-----------------------------+ Serial (no -j option): no change (575 ms).
|
@Haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @collinw, @tiran and @freddrake to be potential reviewers. |
Member
Author
|
The patch is a first draft to discuss the change, it must be polished to not break the API. |
vstinner
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the build_ext of distutils to call newer_group() in serial
mode even if the parallel mode is used, instead of calling
newer_group() in threads, to avoid a slowdown caused by the GIL on
os.stat().
Benchmark with 4 logical CPUs (2 physical cores)
on "./python -E ./setup.py build":
Serial (no -j option): no change (575 ms).