X Tutup
The Wayback Machine - https://web.archive.org/web/20201003201049/https://github.com/Respect/Validation/pull/191
Skip to content

/ Validation

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links for rules on README #191

Merged
merged 1 commit into from Jul 15, 2014
Merged

Links for rules on README #191

merged 1 commit into from Jul 15, 2014

Conversation

@malukenho
Copy link

@malukenho malukenho commented Jun 27, 2014

  • Remove entry v::uppercase() duplicated
  • Insert Links on list of methods

See #190
@augustohp augustohp added this to the 0.7.0 milestone Jun 28, 2014
@augustohp
Copy link
Member

@augustohp augustohp commented Jun 28, 2014

Awesome job! 🍻 Can you also put links on the "See also" sections of each validator?
@augustohp
Copy link
Member

@augustohp augustohp commented Jul 11, 2014

Awesome!

@malukenho Can you rebase both commits into one (I can do that, or help you do that) before we merge it?

I would also take the change during rebase to remove the issue number from the short commit message to the body of the commit, since it is only relevant to Github.
@augustohp augustohp changed the title Insert links for each method on README #190 Links for rules on README Jul 11, 2014
Jefersson Nathan
Links of rules on README.
Loading status checks…
2ce3685 
All references to rules inside the README now have
a link to the corresponding section into the documentation.

Fixes #190 on GitHub.
augustohp added a commit that referenced this pull request Jul 15, 2014
@augustohp
Merge pull request #191 from malukenho/patch-3
Loading status checks…
880f02b 
Links for rules on README.
@augustohp augustohp merged commit 880f02b into Respect:master Jul 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
0.7
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@malukenho @augustohp
You can’t perform that action at this time.
X Tutup