X Tutup
Skip to content

Catch ServerNotFoundError to retry the request#532

Merged
theacodes merged 1 commit intogoogleapis:masterfrom
bashir2:catch_ServerNotFoundError
Jun 25, 2018
Merged

Catch ServerNotFoundError to retry the request#532
theacodes merged 1 commit intogoogleapis:masterfrom
bashir2:catch_ServerNotFoundError

Conversation

@bashir2
Copy link
Contributor

@bashir2 bashir2 commented Jun 24, 2018

Fixes: #529

Tested:
Updated HttpMockWithErrors to raise ServerNotFoundError and checked that the tests failed without the fix.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2018
@theacodes theacodes merged commit c35150f into googleapis:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_retry_request does not catch ServerNotFoundError

3 participants

X Tutup