GH-145692: Convert DEOPT_IFs to EXIT_IFs#145751
Open
markshannon wants to merge 1 commit intopython:mainfrom
Open
GH-145692: Convert DEOPT_IFs to EXIT_IFs#145751markshannon wants to merge 1 commit intopython:mainfrom
markshannon wants to merge 1 commit intopython:mainfrom
Conversation
markshannon
changed the title
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Looks pretty good to me, just a comment on two areas.
| EXIT_IF(!_PyLong_IsNonNegativeCompact((PyLongObject *)sub)); | ||
| Py_ssize_t index = ((PyLongObject*)sub)->long_value.ob_digit[0]; | ||
| DEOPT_IF(!LOCK_OBJECT(list)); | ||
| EXIT_IF(!LOCK_OBJECT(list)); |
Member
There was a problem hiding this comment.
Not sure we have any reprise for things that fail on LOCK_OBJECT (ie a side trace wouldn't help). So I would't bother with it for this and below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR, in theory, allows more code to be jitted.
EXIT_IFbranches to a side exit, allowing it to be jitted once it has warmed up, whereDEOPT_IFalways exits to the interpreter.In practice this doesn't seem to make much difference, but it does unblock other work to jit more code.
Performance is generally neutral, less than 1% faster or slower across 5 different platforms.
DEOPT_IFs in bytecodes.c #145692