X Tutup
Skip to content

CI Failure DoctorCI Failure - Run #22832374633 — Coverage regression in ExecutableNormalizedOperationFactory and QueryDirectivesImpl #4309

@github-actions

Description

@github-actions

Failure Details

Failed Jobs and Errors

The per-class coverage gate detected these regressions:

Per-class coverage regressions detected:
  graphql.normalized.ExecutableNormalizedOperationFactory  Line: 84.0% (was 92.0%, delta -8.0%)
  graphql.normalized.ExecutableNormalizedOperationFactory  Method: 75.0% (was 87.5%, delta -12.5%)
  graphql.execution.directives.QueryDirectivesImpl         Line: 97.3% (was 97.6%, delta -0.4%)
  graphql.execution.directives.QueryDirectivesImpl         Branch: 75.0% (was 80.0%, delta -5.0%)
  graphql.execution.directives.QueryDirectivesImpl         Method: 93.8% (was 94.4%, delta -0.7%)

Update test-baseline.json if these changes are intentional.

Root Cause

PR #4297 adds a new OperationDirectivesResolver directivesResolver field to ExecutableNormalizedOperationFactoryImpl (in src/main/java/graphql/normalized/ExecutableNormalizedOperationFactory.java) and calls directivesResolver.resolveDirectivesByName(...) inside createNormalizedQueryImpl(). This adds new code to ExecutableNormalizedOperationFactory that is not covered by existing tests for that class, causing a significant drop in line and method coverage.

QueryDirectivesImpl suffers a smaller coverage regression likely due to changes in how directive resolution is tested through the updated execution path.

Recommended Fix

  • Either update test-baseline.json to reflect the new coverage numbers (if the regressions are acceptable), OR
  • Add tests to ExecutableNormalizedOperationFactory-related test classes that exercise operations with directives (e.g., query @foo { field }) to recover coverage for the new directivesResolver.resolveDirectivesByName(...) call path in ExecutableNormalizedOperationFactory.java.

Generated by CI Failure Doctor

To install this workflow, run gh aw add githubnext/agentics/workflows/ci-doctor.md@ee50a3b7d1d3eb4a8c409ac9409fd61c9a66b0f5. View source at https://github.com/githubnext/agentics/tree/ee50a3b7d1d3eb4a8c409ac9409fd61c9a66b0f5/workflows/ci-doctor.md.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      X Tutup