X Tutup
Skip to content

True color support in WebGL renderer#2552

Merged
Tyriar merged 25 commits intoxtermjs:masterfrom
Tyriar:webgl_compat_attr
Nov 10, 2019
Merged

True color support in WebGL renderer#2552
Tyriar merged 25 commits intoxtermjs:masterfrom
Tyriar:webgl_compat_attr

Conversation

@Tyriar
Copy link
Member

@Tyriar Tyriar commented Nov 10, 2019

Fixes #2248
Fixes #2249
Fixes #2250

@Tyriar Tyriar added this to the 4.3.0 milestone Nov 10, 2019
@Tyriar Tyriar self-assigned this Nov 10, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Nov 10, 2019

On selection color, currently the default is #FFFFFF77 which would draw pure white on WebGL. I guess WebGL needs to resolve the alpha value against the background in order to keep both renderers to look approximately the same when using alpha values.

@Tyriar
Copy link
Member Author

Tyriar commented Nov 10, 2019

Selection works now based on the computed selectionOpaque value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webgl: Support custom selection colors Webgl: Support true color rendering Webgl: Remove CharDataCompat

1 participant

X Tutup