Fix kart_charteristics.xml parser generator marker tag detection regex#5642
Open
Nomagno wants to merge 1 commit intosupertuxkart:BalanceSTK2from
Open
Fix kart_charteristics.xml parser generator marker tag detection regex#5642Nomagno wants to merge 1 commit intosupertuxkart:BalanceSTK2from
Nomagno wants to merge 1 commit intosupertuxkart:BalanceSTK2from
Conversation
Nomagno
changed the title
Contributor
Author
|
Whoops, turns out the issue was with escape sequences in the python script regex, not just the marker tags. Fixed now |
Member
|
So this commit mostly changes the order things are in to match what's generated by the script? |
Contributor
Author
|
Yes. Category names can't contain dashes so I had to change Nitro-Hack to NitroHack among other things, and from there I just regenerated everything to keep consistency. Regenerating everything also gets the xml_characteristics.cpp to a consistent format. If merged, commits related to new kart characteristics after this would be back to being small and would just need to follow the simple procedure detailed in https://forum.supertuxkart.net/thread-244.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few simple typos and/or code requirements desync have kept this from working properly for a long while.
Agreement