fix(golang): keep files like changelogs, version, ...#247
Open
rubenhoenle wants to merge 1 commit intomainfrom
Open
fix(golang): keep files like changelogs, version, ...#247rubenhoenle wants to merge 1 commit intomainfrom
rubenhoenle wants to merge 1 commit intomainfrom
Conversation
bug only occured when compat layer was disabled for the generated service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug only occured when compat layer was disabled for the generated service
Description
This fixes a bug where the Go SDK generator removes the files like
CHANGELOG.md,VERSION,NOTICE.txt.Bug only occurs for services which don't have a compatibility layer generated.
See e.g. the new VPN SDK module: stackitcloud/stackit-sdk-go#5855
Testing instructions
Verify the old Go SDK generator behavior
make download-oasmake generate-go-sdkcd sdk-repo-updated/services/vpn). There should be a git diff (the files likeCHANGELOG.md,VERSION,NOTICE.txtare gone)Verify the new Go SDK generator behavior
make download-oasmake generate-go-sdkcd sdk-repo-updated/services/vpn). There should be no git diff (which means the files likeCHANGELOG.md,VERSION,NOTICE.txtare still present as intended).