Allow comments in configuration file#602
Merged
brianmay merged 2 commits intosshuttle:masterfrom Feb 15, 2021
khink:allow-comments-in-config-file
Merged
Allow comments in configuration file#602brianmay merged 2 commits intosshuttle:masterfrom khink:allow-comments-in-config-file
brianmay merged 2 commits intosshuttle:masterfrom
khink:allow-comments-in-config-file
Conversation
khink
changed the title
brianmay
approved these changes
Feb 15, 2021
Contributor
Author
|
@brianmay Thanks for the merge! Any idea when this will be released? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #562, i'd like to submit a patch which allows comments in the configuration file.
The test supplied with this patch does not seem to convincing to me, but once you accept that argparse completely ignores empty lists returned from
convert_arg_line_to_argsthen it makes sense.Of course, i'm open to improvements.