Douglas Adams and Deep Thought was wrong, 42 is not the answer#490
Merged
brianmay merged 1 commit intosshuttle:masterfrom Jul 17, 2020
Merged
Douglas Adams and Deep Thought was wrong, 42 is not the answer#490brianmay merged 1 commit intosshuttle:masterfrom
brianmay merged 1 commit intosshuttle:masterfrom
Conversation
Member
|
I actually hate this hack, and have considered removing it, but not quite game enough... Thanks for the patch. |
Contributor
Author
|
Thanks a lot, @brianmay 👍 |
skuhl
added a commit
to skuhl/sshuttle
that referenced
this pull request
Jul 12, 2021
Previously, it was possible to run sshuttle locally without using ssh and connecting to a remote server. In this configuration, traffic was redirected to the sshuttle server running on the localhost. However, the firewall needed to distinguish between traffic leaving the sshuttle server and traffic that originated from the machine that still needed to be routed through the sshuttle server. The TTL of the packets leaving the sshuttle server were manipulated to indicate to the firewall what should happen. The TTL was adjusted for all packets leaving the sshuttle server (even if it wasn't necessary because the server and client were running on different machines). Changing the TTL caused trouble and some machines, and the --ttl option was added as a workaround to change how the TTL was set for traffic leaving sshuttle. All of this added complexity to the code for a feature (running the server on localhost) that is likely only used for testing and rarely used by others. This commit updates the associated documentation, but doesn't fully fix the ipfw method since I am unable to test that. This change will also make sshuttle fail to work if -r is used to specify a localhost. Pull request sshuttle#610 partially addresses that issue. For example, see: sshuttle#240, sshuttle#490, sshuttle#660, sshuttle#606.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might come as a surprise but some cross-region connections between AWS us-east-1 and AWS us-west-2 are currently routing through more than 42 hops. I might be wrong but if we can set the IP4 TTL to any non-default number 63 might be a better choice to get us close to the Linux default of 64?