This repository was archived by the owner on Dec 16, 2024. It is now read-only.
Handle Homebrew renaming mobile-shell to mosh#724
Merged
bors-servo merged 1 commit intoservo:masterfrom Sep 30, 2017
Merged
Conversation
Homebrew left in an alias for `mobile-shell` so the `mosh` package actually installs correctly, but Salt's pkg.installed state then tries to verify the installation by checking the installed packages. That list only shows `mosh` and not the `mobile-shell` alias, causing the state the fail. Update to the new name, which is also consistent with everyone else.
Contributor
Author
|
The upstream change is at Homebrew/homebrew-core#18636. r? @larsbergstrom or @edunham |
Contributor
|
@bors-servo r+ |
Contributor
|
📌 Commit db0781e has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Sep 30, 2017
…ergstrom Handle Homebrew renaming `mobile-shell` to `mosh` Homebrew left in an alias for `mobile-shell` so the `mosh` package actually installs correctly, but Salt's pkg.installed state then tries to verify the installation by checking the installed packages. That list only shows `mosh` and not the `mobile-shell` alias, causing the state the fail. Update to the new name, which is also consistent with everyone else. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/724) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew left in an alias for
mobile-shellso themoshpackageactually installs correctly, but Salt's pkg.installed state then tries
to verify the installation by checking the installed packages.
That list only shows
moshand not themobile-shellalias,causing the state the fail.
Update to the new name, which is also consistent with everyone else.
This change is