DIRECTOR: Remove unnecessary chunk.h file#6776
Merged
sev- merged 1 commit intoscummvm:masterfrom Jun 26, 2025
Merged
Conversation
Originally intended to be used for saving Chunk data into structs Idea scrapped since then since it doesn't provide any value
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the chunk.h file added in the previous PR #6769
The idea originally seemed valid, since it organizes the chunk data
But since then the idea has been scrapped because it doesn't really provide any concrete value