PSP2: Remove psp2shell dependency#6763
Merged
bluegr merged 2 commits intoscummvm:masterfrom Jun 22, 2025
Merged
Conversation
psp2shell as a dependency is not needed for debug. In fact, it does not even work with current code. We simply need to remove it and use sceClibPrintf. This standard function will send debug messages to psp2shell if it is installed on the console.
ccawley2011
reviewed
Jun 21, 2025
| void OSystem_PSP2::logMessage(LogMessageType::Type type, const char *message) { | ||
| #if __PSP2_DEBUG__ | ||
| psp2shell_print(message); | ||
| sceClibPrintf(message); |
Member
There was a problem hiding this comment.
Would it make sense to remove the __PSP2_DEBUG__ check now that a separate library is no longer required?
Contributor
Author
There was a problem hiding this comment.
Yes. I just pushed another commit that completely removes PSP2_DEBUG as it is not used anymore + adds error logging to file as it was not working.
Contributor
|
Thanks, it looks good to me! |
rsn8887
approved these changes
Jun 22, 2025
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
psp2shell as a dependency is not needed for debug.
In fact, it does not even work with current code.
We simply need to remove it and use sceClibPrintf.
This standard function will send debug messages to psp2shell if it is installed on the console.
Tested and working for me.