FREESCAPE: Reduce pixel format conversion when loading images#6744
Merged
bluegr merged 1 commit intoscummvm:masterfrom Jun 30, 2025
Merged
FREESCAPE: Reduce pixel format conversion when loading images#6744bluegr merged 1 commit intoscummvm:masterfrom
bluegr merged 1 commit intoscummvm:masterfrom
Conversation
ccawley2011
force-pushed
the
freescape-pixel-format
branch
from
712d0cc to
357437c
Compare
neuromancer
reviewed
Jun 19, 2025
| namespace Image { | ||
|
|
||
| ScrDecoder::ScrDecoder() : _surface(nullptr), _palette(0) { | ||
| static const byte scrPalette[16 * 3] = { |
Contributor
There was a problem hiding this comment.
Why this was hardcoded here?
Member
Author
There was a problem hiding this comment.
It doesn't seem to be possible to specify an alternative palette within the file, and it's small enough (48 bytes) that it's probably not worth generating it at runtime.
Contributor
|
Tested it and it works fine, let's merge it |
Member
|
Thanks for your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.