X Tutup
Skip to content

AWE: Implement playSfxMusic#6733

Merged
sev- merged 1 commit intoscummvm:masterfrom
scemino:awe
Jun 19, 2025
Merged

AWE: Implement playSfxMusic#6733
sev- merged 1 commit intoscummvm:masterfrom
scemino:awe

Conversation

@scemino
Copy link
Contributor

@scemino scemino commented Jun 17, 2025

This little pull request is a proposed implementation of the original music, more specifically the playSfxMusic method.

@ccawley2011
Copy link
Member

Is this the same format used by Cine that's supported in common code? https://github.com/scummvm/scummvm/blob/master/audio/mods/soundfx.cpp

@scemino
Copy link
Contributor Author

scemino commented Jun 17, 2025

Is this the same format used by Cine that's supported in common code? https://github.com/scummvm/scummvm/blob/master/audio/mods/soundfx.cpp

Yes I suppose, actually this is a MOD player, this was really frequent in Amiga games.

@sev-
Copy link
Member

sev- commented Jun 19, 2025

Thank you!

@sev- sev- merged commit c6a4275 into scummvm:master Jun 19, 2025
8 checks passed
@tag2015
Copy link
Contributor

tag2015 commented Jun 20, 2025

It seems stopSfxMusic must be implemented as well.
Password input is basically broken now, when you enter a password the game asserts out almost always
Assertion failed: pat.note_1 >= 0x37 && pat.note_1 < 0x1000, file engines/awe/sfx_player.cpp, line 251
If you disable the assertion you can proceed, but then the sound is all messed up.

Also when you quit/close the game ScummVM doesn't close cleanly, I always get a segfault

@tag2015
Copy link
Contributor

tag2015 commented Jun 20, 2025

Well, there's no need to use the password. Just complete the first part, it'll crash when you are in the cage

@scemino
Copy link
Contributor Author

scemino commented Jun 20, 2025

Well, there's no need to use the password. Just complete the first part, it'll crash when you are in the cage

You're right, I'm fixing it right away.

@scemino
Copy link
Contributor Author

scemino commented Jun 20, 2025

@tag2015 done !

@tag2015
Copy link
Contributor

tag2015 commented Jun 21, 2025

@tag2015 done !

Working fine, nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup