GUI: Fixes and cleanup when removing games#6701
Merged
bluegr merged 3 commits intoscummvm:masterfrom Jun 10, 2025
Merged
Conversation
Fixes launcher scrolling when removing a game
Fixes the wrong item being selected when grouping is enabled
criezy
approved these changes
Jun 10, 2025
Member
criezy
left a comment
criezy
left a comment
There was a problem hiding this comment.
Nice.
While working on other improvements for the grouped list widget (PR #6704) I also wanted to remove the scrolling when selecting an item that is already visible. So it's a change I approve of 😄
And the other changes also look good.
Member
|
Thank you, this behavior has bugged me as well. The changes look good and straightforward. I've tested this, and it works great. Thanks for your work on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the launcher unnecessarily scrolling the list when removing a game. For a user such as myself with more than a full screen of games, this caused the list to confusingly jump around unpredictably. Now scrolling only occurs when setting a selection if the item isn't already visible, instead of always trying to re-scroll the newly selected item to the center.
While testing the scroll change, I found that list item selection doesn't work when grouping is enabled due an off-by-one bug from last year in da3c3d0, so that's fixed too.
This took a while to figure out because many supporting functions were named
getNextPos, but there was nothing "next" about them, so I've renamed them.